danielhoherd commented on code in PR #27848:
URL: https://github.com/apache/airflow/pull/27848#discussion_r1030785910
##########
chart/templates/_helpers.yaml:
##########
@@ -214,8 +214,10 @@ If release name contains chart name it will be used as a
full name.
value: "repo"
- name: GIT_SYNC_ADD_USER
value: "true"
- - name: GIT_SYNC_WAIT
+ - name: GIT_SYNC_WAIT # Deprecated: use GIT_SYNC_PERIOD
value: {{ .Values.dags.gitSync.wait | quote }}
+ - name: GIT_SYNC_PERIOD
+ value: {{ .Values.dags.gitSync.period | quote }}
Review Comment:
Oh, but I do see a problem with my implementation... Maybe a better way to
do it is to only include `period`, and just use the value from `wait` in that
place if it is given.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
