danielhoherd commented on code in PR #27848:
URL: https://github.com/apache/airflow/pull/27848#discussion_r1030783942
##########
chart/templates/_helpers.yaml:
##########
@@ -214,8 +214,10 @@ If release name contains chart name it will be used as a
full name.
value: "repo"
- name: GIT_SYNC_ADD_USER
value: "true"
- - name: GIT_SYNC_WAIT
+ - name: GIT_SYNC_WAIT # Deprecated: use GIT_SYNC_PERIOD
value: {{ .Values.dags.gitSync.wait | quote }}
+ - name: GIT_SYNC_PERIOD
+ value: {{ .Values.dags.gitSync.period | quote }}
Review Comment:
What is the advantage of delaying support of the new flag? New deployments
can start using it right away and not have to migrate to it at a later date.
Existing deployments can migrate during deprecation period to avoid a straight
cut-over where the version and the helm values have to all be changes at the
same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
