ferruzzi commented on code in PR #28236:
URL: https://github.com/apache/airflow/pull/28236#discussion_r1043848248
##########
airflow/providers/amazon/aws/hooks/eks.py:
##########
@@ -596,3 +597,6 @@ def fetch_access_token_for_cluster(self, eks_cluster_name:
str) -> str:
# remove any base64 encoding padding:
return "k8s-aws-v1." + base64_url.rstrip("=")
+
+ def get_waiter(self, waiter_name):
+ return EksBotoWaiter(client=self.conn).waiter(waiter_name)
Review Comment:
so a basehook solution might look like
```
def get_waiter(self):
client_name = self,conn.something
config_path = Path(__file__).with_name(f"{client_name}.json").resolve()
with open(config_path) as config_file:
self.default_config = json.load(config_file)
return BaseBotoWaiter(client=client_name,
model_config=self.default_config)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
