ferruzzi commented on code in PR #28236:
URL: https://github.com/apache/airflow/pull/28236#discussion_r1044796643


##########
airflow/providers/amazon/aws/hooks/eks.py:
##########
@@ -596,3 +597,6 @@ def fetch_access_token_for_cluster(self, eks_cluster_name: 
str) -> str:
 
         # remove any base64 encoding padding:
         return "k8s-aws-v1." + base64_url.rstrip("=")
+
+    def get_waiter(self, waiter_name):
+        return EksBotoWaiter(client=self.conn).waiter(waiter_name)

Review Comment:
   The file you linked at `dev/provider_packages/MANIFEST_TEMPLATE.in.jinja2` 
has a message in it saying
   
   ```
   # IF YOU WANT TO MODIFY IT, YOU SHOULD MODIFY THE TEMPLATE
   # `MANIFEST_TEMPLATE.py.jinja2` IN the `provider_packages` DIRECTORY
   ```
   
   but there is no file by that name.  Do you know if that's an old warning 
that should be removed/ignored?
   
   ```
   ferruzzi:~/workplace/airflow$ find . -name MANIFEST_TEMPLATE*
   ./dev/provider_packages/MANIFEST_TEMPLATE.in.jinja2
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to