ferruzzi commented on code in PR #28236:
URL: https://github.com/apache/airflow/pull/28236#discussion_r1043895020
##########
airflow/providers/amazon/aws/hooks/eks.py:
##########
@@ -596,3 +597,6 @@ def fetch_access_token_for_cluster(self, eks_cluster_name:
str) -> str:
# remove any base64 encoding padding:
return "k8s-aws-v1." + base64_url.rstrip("=")
+
+ def get_waiter(self, waiter_name):
+ return EksBotoWaiter(client=self.conn).waiter(waiter_name)
Review Comment:
I think I got this figured out and it's even cleaner. I am also adding some
unit tests and need to update the README to match so I'll have an update maybe
tonight or tomorrow.
get_waiter now lives in
`airflow.providers.amazon.aws.hooks.base_aws.AwsGenericHook.get_waiter` and no
change needs to be made tot he service hook to implement it. :+1: The code
is a little more complicated than before, but new additions are easier so
that's a net plus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
