Taragolis commented on code in PR #28321:
URL: https://github.com/apache/airflow/pull/28321#discussion_r1046926243
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -151,8 +155,9 @@ def __init__(
self.job_name = job_name
self.job_definition = job_definition
self.job_queue = job_queue
- self.overrides = overrides or {}
- self.array_properties = array_properties or {}
+ self.container_overrides = overrides
+ self.node_overrides = node_overrides
Review Comment:
Just a question. Did you check are this arguments mutually exclusive?
[AWS
API](https://docs.aws.amazon.com/batch/latest/APIReference/API_SubmitJob.html)
doesn't mention it however everything might possible because even new
[eksPropertiesOverride](https://docs.aws.amazon.com/batch/latest/APIReference/API_SubmitJob.html#API_SubmitJob_RequestSyntax)
not marked as exclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
