Taragolis commented on code in PR #28321:
URL: https://github.com/apache/airflow/pull/28321#discussion_r1051085532
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -108,12 +110,13 @@ class BatchOperator(BaseOperator):
"job_queue",
"overrides",
Review Comment:
@camilleanne @vandonr-amz I recommend deprecate old parameter but keep it
for a while, so users would have a time for change their code.
It is much easier achieve in subclasss of `BaseOperator` (this PR case),
because all arguments are keyword.
Some examples
**Use old attribute value only if new attribute not set**
https://github.com/apache/airflow/blob/11f30a887c77f9636e88e31dffd969056132ae8c/airflow/providers/slack/operators/slack_webhook.py#L95-L104
**Use old attribute value only if it equal new attribute value or not new
attribute not set**
https://github.com/apache/airflow/blob/11f30a887c77f9636e88e31dffd969056132ae8c/airflow/providers/amazon/aws/operators/athena.py#L91-L101
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -108,12 +110,13 @@ class BatchOperator(BaseOperator):
"job_queue",
"overrides",
Review Comment:
@camilleanne @vandonr-amz I recommend deprecate old parameter but keep it
for a while, so users would have a time for change their code.
It is much easier achieve in subclass of `BaseOperator` (this PR case),
because all arguments are keyword.
Some examples
**Use old attribute value only if new attribute not set**
https://github.com/apache/airflow/blob/11f30a887c77f9636e88e31dffd969056132ae8c/airflow/providers/slack/operators/slack_webhook.py#L95-L104
**Use old attribute value only if it equal new attribute value or not new
attribute not set**
https://github.com/apache/airflow/blob/11f30a887c77f9636e88e31dffd969056132ae8c/airflow/providers/amazon/aws/operators/athena.py#L91-L101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
