vandonr-amz commented on code in PR #28321:
URL: https://github.com/apache/airflow/pull/28321#discussion_r1051041510


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -108,12 +110,13 @@ class BatchOperator(BaseOperator):
         "job_queue",
         "overrides",

Review Comment:
   TIL the names here need to match not the parameter name in the ctor but the 
name of the attribute in the class, so:
   ```suggestion
           "container_overrides",
   ```
   
   Thinking about it, I wonder if this is a breaking change... I don't know too 
well how this works 😬 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to