vincbeck commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1090988266
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -679,11 +697,11 @@ def __init__(
self.check_interval = check_interval
self.max_ingestion_time = max_ingestion_time
self.check_if_job_exists = check_if_job_exists
- if action_if_job_exists in ("increment", "fail"):
+ if action_if_job_exists in {"random", "increment", "fail"}:
Review Comment:
If I understand well, `increment` value is deprecated but if you set it, the
behavior is the same as `random`? I am wondering if we should not keep the
current behavior if `increment` is set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
