vandonr-amz commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1090996944
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -679,11 +697,11 @@ def __init__(
self.check_interval = check_interval
self.max_ingestion_time = max_ingestion_time
self.check_if_job_exists = check_if_job_exists
- if action_if_job_exists in ("increment", "fail"):
+ if action_if_job_exists in {"random", "increment", "fail"}:
Review Comment:
yes your understanding is correct.
We can be extra cautious and keep the existing behavior, as it's a change,
but it's not a "breaking" change.
I think the "increment" behavior is a bit dangerous because it's just
problems waiting to happen if you use it, so I'd rather remove it entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
