mhenc commented on code in PR #29355:
URL: https://github.com/apache/airflow/pull/29355#discussion_r1100292662
##########
airflow/models/taskinstance.py:
##########
@@ -448,21 +448,30 @@ class TaskInstance(Base, LoggingMixin):
note = association_proxy("task_instance_note", "content",
creator=_creator_note)
task: Operator # Not always set...
- def __init__(
- self,
+ @staticmethod
+ def from_task(
Review Comment:
I made changes that @kosteev suggested - with additional optional parametr
to the constructor, while keepign the from_task static methods so users can
slowly migrate there.
On the other hand @bolkedebruin has some concerns about this approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
