bolkedebruin commented on code in PR #29355:
URL: https://github.com/apache/airflow/pull/29355#discussion_r1100488514
##########
airflow/serialization/serialized_objects.py:
##########
@@ -502,6 +504,8 @@ def deserialize(cls, encoded_var: Any) -> Any:
return Dataset(**var)
elif type_ == DAT.SIMPLE_TASK_INSTANCE:
return SimpleTaskInstance(**cls.deserialize(var))
+ elif type_ == DAT.TASK_INSTANCE:
Review Comment:
Given that you are going to rely on a lot of serialization and the new
serializer/deserializer is significantly faster and more future proof
(versioning) I think everything that does currently not have a schema (that's
everything except a DAG*) should switch.
I am willing to help out to ease the migration if required.
* I am working on DAG serialization/deserialization but untangling how it is
done now and to improve the structure is taking time especially with all the
edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
