mhenc commented on code in PR #29355:
URL: https://github.com/apache/airflow/pull/29355#discussion_r1104169696


##########
airflow/serialization/serialized_objects.py:
##########
@@ -502,6 +504,8 @@ def deserialize(cls, encoded_var: Any) -> Any:
             return Dataset(**var)
         elif type_ == DAT.SIMPLE_TASK_INSTANCE:
             return SimpleTaskInstance(**cls.deserialize(var))
+        elif type_ == DAT.TASK_INSTANCE:

Review Comment:
   yes, we need to make change there and server-side:
   
https://github.com/apache/airflow/blob/main/airflow/api_internal/endpoints/rpc_api_endpoint.py#L76
   
   There are more methods with `internal_api_call` decorator. I did a quick 
check and I see that (beside primitives) we already need serialization to 
Dag,DagRun, BaseXCom, CallbackRequest (and probably more soon)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to