1inuxoid commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1109799460
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -135,7 +156,7 @@ def execute(self, context: Context) -> None:
raise e
finally:
if err is None:
- _upload_file_to_s3(f, self.s3_bucket_name,
self.s3_key_prefix, self.aws_conn_id)
+ _upload_file_to_s3(f, self.s3_bucket_name,
self.s3_key_prefix, str(self.dest_aws_conn_id))
Review Comment:
Because of the signature of `_upload_file_to_s3` which expects aws_conn_id
to be a string
[here](https://github.com/apache/airflow/pull/29452/files/150b2a0407d066bbe15a764ada315718f88615fa#diff-5a4b3715577fad0a7bbf023f861a5f4f1e0fb1abb4b2a71ecb804a068d9de4edR62).
As you can see, `aws_conn_id` was always defined as type `str`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
