1inuxoid commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1109812718
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -103,12 +114,14 @@ def __init__(
self,
*,
dynamodb_table_name: str,
+ source_aws_conn_id: str = "aws_default",
Review Comment:
On one side I agree that this typing would make more sense, however, the old
implementation had `aws_conn_id` typed as `str` so people would just ignore
they typing error messages when they would use `None` as a value? Contrary to
the documentation, it only supported empty string before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
