1inuxoid commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1109807591
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -32,11 +33,17 @@
from airflow.models import BaseOperator
from airflow.providers.amazon.aws.hooks.dynamodb import DynamoDBHook
from airflow.providers.amazon.aws.hooks.s3 import S3Hook
+from airflow.utils.types import NOTSET, ArgNotSet
if TYPE_CHECKING:
from airflow.utils.context import Context
+_DEPRECATION_MSG = (
+ "The aws_conn_id parameter has been deprecated. You should pass instead
the source_aws_conn_id parameter."
Review Comment:
I think as we are not dropping it and the new code matches the behaviour of
the old one if you only use `aws_conn_id`, just adding a deprecation warning,
we are not twisting anyones hands too much.
On the other side, keeping all 3 connection parameters while only using
maximum 2 out of them is not very clean, IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
