vandonr-amz commented on code in PR #29911:
URL: https://github.com/apache/airflow/pull/29911#discussion_r1134438519
##########
airflow/providers/amazon/aws/waiters/appflow.json:
##########
@@ -0,0 +1,30 @@
+{
+ "version": 2,
+ "waiters": {
+ "run_complete": {
+ "operation": "DescribeFlowExecutionRecords",
+ "delay": 15,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "expected": "Successful",
+ "matcher": "path",
+ "state": "success",
+ "argument":
"flowExecutions[?executionId=='<EXECUTION_ID>'].executionStatus"
Review Comment:
I can do something relatively simple like
template = Template(config)
return template.render(parameters)
but then we lose all the checks on whether variables are provided or not, or
if too many of them were present.
Just tried it, and if we forget to pass the variable for the template, jinja
replaces them with an empty string, which can lead to surprising silent
behavior I think. Like, if we use it to pass the name of a job that should
appear in a list for instance (as I plan to do), we might wait forever for a
job with empty name, and it could be quite hard to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
