vandonr-amz commented on code in PR #29911:
URL: https://github.com/apache/airflow/pull/29911#discussion_r1134484142
##########
airflow/providers/amazon/aws/waiters/appflow.json:
##########
@@ -0,0 +1,30 @@
+{
+ "version": 2,
+ "waiters": {
+ "run_complete": {
+ "operation": "DescribeFlowExecutionRecords",
+ "delay": 15,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "expected": "Successful",
+ "matcher": "path",
+ "state": "success",
+ "argument":
"flowExecutions[?executionId=='<EXECUTION_ID>'].executionStatus"
Review Comment:
...but then as we handle the configuration for all the waiters at once, it'd
fail/warn if params for other waiters are missing, which is bad. We'd have to
systematically reconstruct a json for only the waiter we're going to use.
It'd be:
- json parse
- remove all waiters we're not interested in from ["waiters"]
- convert to string again, do jinja magic on string
- parse to json again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
