potiuk commented on code in PR #30255: URL: https://github.com/apache/airflow/pull/30255#discussion_r1147255277
########## airflow/cli/commands/standalone_command.py: ########## @@ -30,8 +30,9 @@ from airflow.configuration import AIRFLOW_HOME, conf, make_group_other_inaccessible from airflow.executors import executor_constants from airflow.executors.executor_loader import ExecutorLoader -from airflow.jobs.scheduler_job import SchedulerJob -from airflow.jobs.triggerer_job import TriggererJob +from airflow.jobs.job_runner import BaseJobRunner +from airflow.jobs.scheduler_job import SchedulerJobRunner Review Comment: Yes. I plan to rename them to `_runner` as a follow-up PR. Just wanted to have a change that is super-easy to review and track changes fo - it's more difficult to review code that does both - changes and renames even if git is able to get some of those under control and get both modified and renamed files in most cases (but it is based on a heuristics and a number of changes, so it might go wrong because a number of changes is not small. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
