potiuk commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1148081776
##########
airflow/cli/commands/standalone_command.py:
##########
@@ -235,13 +236,13 @@ def port_open(self, port):
return False
return True
- def job_running(self, job):
+ def job_running(self, job_runner_class: type[BaseJobRunner]):
"""
Checks if the given job name is running and heartbeating correctly.
Used to tell if scheduler is alive.
"""
- recent = job.most_recent_job()
+ recent = job_runner_class.most_recent_job()
Review Comment:
Moved it back to base_job (but as a function not a class method). I will
still have to fix the lazy loading on health_check for that one ( some tests
are failing and I need to look at them) - but it should be better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
