mhenc commented on code in PR #30255:
URL: https://github.com/apache/airflow/pull/30255#discussion_r1147726228
##########
airflow/cli/commands/scheduler_command.py:
##########
@@ -46,10 +47,12 @@ def scheduler(args):
"""Starts Airflow Scheduler."""
print(settings.HEADER)
- job = SchedulerJob(
- subdir=process_subdir(args.subdir),
- num_runs=args.num_runs,
- do_pickle=args.do_pickle,
+ job = BaseJob(
Review Comment:
won't it be easier to have it other-way round?
I mean BaseJobRunner having base_job field. so we can get rid of any methods
on BaseJob.
This will allow to use BaseJob|BaseJobPydantic easier as we won't make need
to copy any BaseJob methods to BaseJobPydantic.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
