potiuk commented on PR #30315: URL: https://github.com/apache/airflow/pull/30315#issuecomment-1487187773
> I still think this is hacky and use some workaround things. This wouldn't be required if we had approved PR but unfortunetly this how the things happen, some one PRs more important that others. Which PR? Why was it not approved? I think it's quite a jump you made from not approved PR to things being more important than others, implying a bit bad intentions in general and hinting into some accusations. I do not like this. If there is a problem, please raise it (likely privately if there is a personal problem you are dealing with and do not want to share it in public). I am not even sure if you are trying to point it at me or someone else. I'd advise to reach out possibly to [email protected] if you think you are being treated unfairly - this is one of the reasons why we have private@ list. > I'm not happy with this changes because instead of fix the reason why it initially happen we tried to add new workarounds and hacks (and we for month that test that check doesn't work), and this hacks and workaround could potentially break something in the future. I do not think they will - we often do workaround and hacks temporarily and this one is followed up by two issues to pytest: * https://github.com/pytest-dev/pytest/issues/10845 * https://github.com/pytest-dev/pytest/issues/10844 They might lead to removing the need for the workarounds. This is the usual practice we do here very ofen. I do not see why this would be different this time. And if someone makes a change to follow the conventions - we can easily remove the workarounds - they are environmental and do not change essentialy our tests we run. I see no reason why we should do it differently than what we do usally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
