potiuk commented on code in PR #30315:
URL: https://github.com/apache/airflow/pull/30315#discussion_r1153625511
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -436,6 +440,14 @@ else
echo "${COLOR_YELLOW}Skip ${providers_dir} as the directory
does not exist.${COLOR_RESET}"
fi
done
+ elif [[ ${TEST_TYPE} =~ PlainAsserts ]]; then
+ # Those tests fail when --asert=rewrite is set, therefore we run them
separately
Review Comment:
Yeah. I created them later, but sure. I can add them :) . And yeah. I
absolutely don't love the workarounds either. It took me - unnecessarily at
least couple of good hours and even more hair pulled - this time from the side
of my hair (I seem t to have even less of them now). I actually had to do
bisect on the REGEX pattern (adding letter by letter) in python_files to be
able to find which files are causing the problems.
But yeah. I've learned quite a bit - so it is not entirely lost effort (and
I **just** signed a CLA with datastax as they would not accept my "add one line
of comment" contribution :D...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
