uranusjr commented on code in PR #30308:
URL: https://github.com/apache/airflow/pull/30308#discussion_r1162470469
##########
airflow/jobs/job.py:
##########
@@ -292,3 +281,51 @@ def most_recent_job(job_type: str, session: Session =
NEW_SESSION) -> Job | None
)
.first()
)
+
+
+@provide_session
+def prepare_for_execution(job: Job | JobPydantic, session: Session =
NEW_SESSION):
Review Comment:
I’d argue `run_job` should call the methods directly (instead of the wrapper
functions and go through an extra `isinstance` check), and suggest delay adding
these until they are needed then, since it is difficult to review those
functions properly without knowing how exactly they will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
