jedcunningham commented on code in PR #30308:
URL: https://github.com/apache/airflow/pull/30308#discussion_r1163128690


##########
airflow/jobs/job.py:
##########
@@ -292,3 +281,51 @@ def most_recent_job(job_type: str, session: Session = 
NEW_SESSION) -> Job | None
         )
         .first()
     )
+
+
+@provide_session
+def prepare_for_execution(job: Job | JobPydantic, session: Session = 
NEW_SESSION):

Review Comment:
   I'm not sure the new refactor really helps with the goal of making future 
cherry picks easier. I wonder if we should just do the run_job method to 
function change, and defer the splitting part until we can review it later?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to