ferruzzi commented on code in PR #30496:
URL: https://github.com/apache/airflow/pull/30496#discussion_r1164482520
##########
airflow/models/taskinstance.py:
##########
@@ -540,6 +540,10 @@ def __init__(
# can be changed when calling 'run'
self.test_mode = False
+ @property
+ def stats_tags(self) -> dict[str, str]:
+ return prune_dict({"dag_id": self.dag_id, "run_id": str(self.run_id),
"task_id": self.task_id})
Review Comment:
Rethinking this, that was already in there
([here](https://github.com/apache/airflow/blob/main/airflow/models/taskinstance.py#L1266)).
All I did was move it from an inline declaration to a property. So removing
it now would/could/should be considered a breaking change. How strongly do we
feel about that? I'm tempted to leave it in at this point unless there is a
reason to drop it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
