dnskr commented on PR #30569: URL: https://github.com/apache/airflow/pull/30569#issuecomment-1505839307
I've added the following headers similar to other templates: 1. `chart/template/dags-persistent-volume-claim.yaml` ```yaml ###################################### ## Airflow DAGs PersistentVolumeClaim ###################################### ``` 2. `chart/template/logs-persistent-volume-claim.yaml` ```yaml ###################################### ## Airflow LOGs PersistentVolumeClaim ###################################### ``` These changes are workaround to fix tests: https://github.com/apache/airflow/blob/0f3b6579cb67d3cf8bd9fa8f9abd502fc774201a/tests/charts/test_dags_persistent_volume_claim.py#L25-L39 https://github.com/apache/airflow/blob/0f3b6579cb67d3cf8bd9fa8f9abd502fc774201a/tests/charts/test_logs_persistent_volume_claim.py#L25-L39 The root cause of the issue is `helm template --show-only` returns error if file (resource ) cannot be found: ```bash $ helm template test chart --set dags.persistence.enabled=False --show-only templates/dags-persistent-volume-claim.yaml Error: could not find template templates/dags-persistent-volume-claim.yaml in chart ``` We need to find another way to check if the resource is not generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
