[ 
https://issues.apache.org/jira/browse/AIRFLOW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889540#comment-16889540
 ] 

ASF subversion and git services commented on AIRFLOW-5004:
----------------------------------------------------------

Commit 0c6c3745d14479a0dea42c02ef8d01e99fd45b32 in airflow's branch 
refs/heads/v1-10-test from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0c6c374 ]

[AIRFLOW-5004] Branch/image for CI builds is selected via TRAVIS_BRANCH

When building CI images you need to know whether you use v1-10-test or
v1-10-stable branch (and use corresponding image).

Currently the default branch is read from _default_branch.sh. This is
not a problem for master/v1-10-test distinction because those are in
different "physical" branches, but v1-10-stable and v1-10-test are
actually following one-another (v1-10-test moves first and
when several commits pass, then stable branch follows).

Therefore we need to utilise TRAVIS_BRANCH variable - this variable
works in two modes - for PRs it is the branch that the PR is going
to be merged to, whereas for triggered builds it's the branch from
which the build was triggered. This is perfect for us to determine
which image should be used during build.


> Stable/test image should be selectable via TRAVIS_BRANCH environment variable
> -----------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5004
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5004
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 1.10.4
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> When building CI images you need to know whether you use v1-10-test or 
> v1-10-stable branch (and use corresponding image).
> Currently the default branch is read from _default_branch.sh . This is not a 
> problem for master/v1-10-test distinction because those are in different 
> "physical" branches, but v1-10-stable and v1-10-test are actually following 
> one-another (v1-10-test moves first and when several commits pass, then 
> stable branch follows).
> Therefore we need to utilise TRAVIS_BRANCH variable - this variable works in 
> two modes - for PRs it is the branch that the PR is going to be merged to, 
> whereas for triggered builds it's the branch from which the build was 
> triggered. This is perfect for us to determine which image should be used 
> during build.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to