[
https://issues.apache.org/jira/browse/AIRFLOW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890650#comment-16890650
]
ASF GitHub Bot commented on AIRFLOW-5004:
-----------------------------------------
potiuk commented on pull request #5624: [AIRFLOW-5004] Branch/image for CI
builds is selected via TRAVIS_BRANCH
URL: https://github.com/apache/airflow/pull/5624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Stable/test image should be selectable via TRAVIS_BRANCH environment variable
> -----------------------------------------------------------------------------
>
> Key: AIRFLOW-5004
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5004
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 1.10.4
> Reporter: Jarek Potiuk
> Priority: Major
>
> When building CI images you need to know whether you use v1-10-test or
> v1-10-stable branch (and use corresponding image).
> Currently the default branch is read from _default_branch.sh . This is not a
> problem for master/v1-10-test distinction because those are in different
> "physical" branches, but v1-10-stable and v1-10-test are actually following
> one-another (v1-10-test moves first and when several commits pass, then
> stable branch follows).
> Therefore we need to utilise TRAVIS_BRANCH variable - this variable works in
> two modes - for PRs it is the branch that the PR is going to be merged to,
> whereas for triggered builds it's the branch from which the build was
> triggered. This is perfect for us to determine which image should be used
> during build.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
