[
https://issues.apache.org/jira/browse/AIRFLOW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889571#comment-16889571
]
ASF GitHub Bot commented on AIRFLOW-5004:
-----------------------------------------
potiuk commented on pull request #5624: [AIRFLOW-5004] [depends on
AIRFLOW-4997, AIRFLOW-4999, AIRFLOW-5001] Branch/image for CI builds is
selected via TRAVIS_BRANCH
URL: https://github.com/apache/airflow/pull/5624
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5004
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
When building CI images you need to know whether you use v1-10-test or
v1-10-stable branch (and use corresponding image).
Currently the default branch is read from _default_branch.sh . This is not a
problem for master/v1-10-test distinction because those are in different
"physical" branches, but v1-10-stable and v1-10-test are actually following
one-another (v1-10-test moves first and when several commits pass, then stable
branch follows).
Therefore we need to utilise TRAVIS_BRANCH variable - this variable works in
two modes - for PRs it is the branch that the PR is going to be merged to,
whereas for triggered builds it's the branch from which the build was
triggered. This is perfect for us to determine which image should be used
during build.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
All tests!
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Stable/test image should be selectable via TRAVIS_BRANCH environment variable
> -----------------------------------------------------------------------------
>
> Key: AIRFLOW-5004
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5004
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 1.10.4
> Reporter: Jarek Potiuk
> Priority: Major
>
> When building CI images you need to know whether you use v1-10-test or
> v1-10-stable branch (and use corresponding image).
> Currently the default branch is read from _default_branch.sh . This is not a
> problem for master/v1-10-test distinction because those are in different
> "physical" branches, but v1-10-stable and v1-10-test are actually following
> one-another (v1-10-test moves first and when several commits pass, then
> stable branch follows).
> Therefore we need to utilise TRAVIS_BRANCH variable - this variable works in
> two modes - for PRs it is the branch that the PR is going to be merged to,
> whereas for triggered builds it's the branch from which the build was
> triggered. This is perfect for us to determine which image should be used
> during build.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
