eladkal commented on PR #30658: URL: https://github.com/apache/airflow/pull/30658#issuecomment-1509877705
> I am aware this operator adds duplication with BigQueryToMySqlOperator and BigQueryToMsSqlOperator. The implementation is basically the same. On the other hand, I feel that factorizing that code would make it unreadable. >The BigQueryToMySqlOperator had a deprecated argument: delegate_to. I removed it from the Postgres adaptation. We should not duplicate code. We should have either `BaseBigQueryToSqlOperator` then each flavour DB can inherit and do the specific things or preferably have a single `BigQueryToSqlOperator` that knows to handle any db hook that uses `DbApiHook`. As for the `delegate_to`. The next provider release is a breaking one. We can handle it now. It's simple as removing the warnings added in https://github.com/apache/airflow/pull/29088 and remove the parameter all together @shahar1 maybe you are up for it? but even if the parameter stays moving to generalized solution makes this a no concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
