jbbqqf commented on PR #30658: URL: https://github.com/apache/airflow/pull/30658#issuecomment-1510515754
> We should not duplicate code. > > We should have either BaseBigQueryToSqlOperator then each flavour DB can inherit and do the specific things or preferably have a single BigQueryToSqlOperator that knows to handle any db hook that uses DbApiHook. @eladkal ok, deal. I refactored the two twin operators with a `BaseBigQueryToSqlOperator` and used it to implement the new `BigQueryToPostgresOperator`. I had to make some tweaks though to remain backward compatible because of subtle differences. I took the opportunity to factorize docstrings. That said, I'm not 100% sure that documenting only two parameters in `BigQueryToPostgresOperator` is the way to go, considering some mandatory parameters handled (and documented) in the parent class, `BaseBigQueryToSqlOperator`, are required. You tell me. The generated documentation looks fine. Here is an example (I also checked the other impacted pages):  The only tests I have not been able to run with Breeze are the example dags in `tests/system/providers/google/cloud/bigquery/`. The command `breeze testing tests tests/system/providers/google/cloud/bigquery/` doesn't seem to do the trick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
