jbbqqf commented on code in PR #30658: URL: https://github.com/apache/airflow/pull/30658#discussion_r1168048017
########## tests/providers/google/cloud/transfers/test_bigquery_to_postgres.py: ########## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from unittest import mock + +from airflow.providers.google.cloud.transfers.bigquery_to_postgres import BigQueryToPostgresOperator + +TASK_ID = "test-bq-create-table-operator" +TEST_DATASET = "test-dataset" +TEST_TABLE_ID = "test-table-id" +TEST_DAG_ID = "test-bigquery-operators" + + +class TestBigQueryToPostgresOperator: + @mock.patch("airflow.providers.google.cloud.transfers.bigquery_to_postgres.BigQueryHook") + def test_execute_good_request_to_bq(self, mock_hook): + destination_table = "table" + operator = BigQueryToPostgresOperator( + task_id=TASK_ID, + dataset_table=f"{TEST_DATASET}.{TEST_TABLE_ID}", + postgres_table=destination_table, + replace=False, + ) + + operator.execute(context=mock.MagicMock()) + # fmt: off Review Comment: I initially copy/pasted the MySQL implementation without thinking too much about it. After digging in the commit history it looks like those `fmt` directives are old artifacts that can be removed with no side effect, which I did. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
