vchiapaikeo commented on code in PR #30655:
URL: https://github.com/apache/airflow/pull/30655#discussion_r1174419762
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -2076,12 +2081,11 @@ def run_query(
labels = labels or self.labels
schema_update_options = list(schema_update_options or [])
+ priority = priority or self.priority
+
if time_partitioning is None:
time_partitioning = {}
- if location:
- self.location = location
-
Review Comment:
I'm not sure if this is used in some other way to propagate location to the
instance attribute. It isn't the right thing to do but at the same time, I'm
worried that an operator was relying on this functionality - especially given
the fact that there was a test around this. Can you check if callers of
run_query were previously relying on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
