ying-w commented on code in PR #30655:
URL: https://github.com/apache/airflow/pull/30655#discussion_r1174436966
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -2076,12 +2081,11 @@ def run_query(
labels = labels or self.labels
schema_update_options = list(schema_update_options or [])
+ priority = priority or self.priority
+
if time_partitioning is None:
time_partitioning = {}
- if location:
- self.location = location
-
Review Comment:
i was just checking what other calls go to `run_query()` and in
hooks/bigquery.py theres only 1 other call from deprecated
[`BigQueryCursor.run_query`](https://github.com/apache/airflow/blob/29fb38cfe3b0f1e54b48e7cc5786ab1c15ab8425/airflow/providers/google/cloud/hooks/bigquery.py#L2655)
which passes in `*args, **kwargs` so might rely on it
in operators/bigquery.py are 2 calls from within the deprecated
`BigQueryExecuteQueryOperator` class just passing through values for
[`execute()`](https://github.com/apache/airflow/blob/29fb38cfe3b0f1e54b48e7cc5786ab1c15ab8425/airflow/providers/google/cloud/operators/bigquery.py#L1097)
but doesn't pass in `location`. Many of these operators set `self.location =
location` and then pass that to `BigQueryHook`
So getting rid of the call from `cursor.execute()` should remove calls to
run_query() from non-deprecated functions
(i checked all references of `run_query` within
airflow/providers/google/cloud/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
