jbbqqf commented on PR #30658:
URL: https://github.com/apache/airflow/pull/30658#issuecomment-1519138880
I made everything I could with the feedback I've received on this PR.
The code is factorized so that the new PostgresOperator is not a copy/paste
version of the Mysql one. The documentation is also as factorized as it can be.
I rebased and removed the `delegate_to` parameter. I eventually managed to
make static checks + build pass thanks to breeze. All CI checks designed to
make sure no doc / tests are forgotten do pass.
I built the documentation locally. It looks fine.
I tested operators with a local airflow / postgresql / mysql + test gcp
project. Basic operations work.
By basic operation I mean I tested those tasks:
```
bigquery_to_mysql = BigQueryToMySqlOperator(
task_id="bigquery_to_mysql",
dataset_table="dataset.table_42",
mysql_table="{{ var.value.get('my_var', 'test') }}",
replace=False,
)
bigquery_to_postgres = BigQueryToPostgresOperator(
task_id="bigquery_to_postgres",
dataset_table="dataset.table_42",
postgres_table="{{ var.value.get('my_var', 'test') }}",
replace=False,
)
```
During my tests I noticed there was an error with `template_fields`. It
should now be fixed.
I performed my local tests with a postgres and a mysql database. I didn't
manually test the mssql operator.
Is there some additional tests I should perform that would cover common
pitfalls?
@eladkal you seem to have some perspective on the airflow project. What is
the next step? How many people should validate the PR so that it can be merged?
:slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
