uranusjr commented on code in PR #31772:
URL: https://github.com/apache/airflow/pull/31772#discussion_r1226221671
##########
airflow/models/dag.py:
##########
@@ -2181,9 +2199,9 @@ def clear(
)
if dry_run:
- return tis
+ return session.scalars(tis).all()
Review Comment:
Need to update the return type annotation of this function to match. But can
we safely change in the first place? Calling `all()` here can be quite slow if
there are a lot of task instances, which may be pretty unexpected for
`dry_run=True`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
