uranusjr commented on code in PR #31772:
URL: https://github.com/apache/airflow/pull/31772#discussion_r1231956794
##########
airflow/models/dag.py:
##########
@@ -223,31 +238,32 @@ def get_dataset_triggered_next_run_info(
"ready": x.ready,
"total": x.total,
}
- for x in session.query(
- DagScheduleDatasetReference.dag_id,
- # This is a dirty hack to workaround group by requiring an
aggregate, since grouping by dataset
- # is not what we want to do here...but it works
- case((func.count() == 1, func.max(DatasetModel.uri)),
else_="").label("uri"),
- func.count().label("total"),
- func.sum(case((DDRQ.target_dag_id.is_not(None), 1),
else_=0)).label("ready"),
- )
- .join(
- DDRQ,
- and_(
- DDRQ.dataset_id == DagScheduleDatasetReference.dataset_id,
- DDRQ.target_dag_id == DagScheduleDatasetReference.dag_id,
- ),
- isouter=True,
- )
- .join(
- DatasetModel,
- DatasetModel.id == DagScheduleDatasetReference.dataset_id,
- )
- .group_by(
- DagScheduleDatasetReference.dag_id,
- )
- .filter(DagScheduleDatasetReference.dag_id.in_(dag_ids))
- .all()
+ for x in session.execute(
+ select(
+ DagScheduleDatasetReference.dag_id,
+ # This is a dirty hack to workaround group by requiring an
aggregate,
+ # since grouping by dataset is not what we want to do
here...but it works
+ case((func.count() == 1, func.max(DatasetModel.uri)),
else_="").label("uri"),
+ func.count().label("total"),
+ func.sum(case((DDRQ.target_dag_id.is_not(None), 1),
else_=0)).label("ready"),
+ )
+ .join(
+ DDRQ,
+ and_(
+ DDRQ.dataset_id == DagScheduleDatasetReference.dataset_id,
+ DDRQ.target_dag_id == DagScheduleDatasetReference.dag_id,
+ ),
+ isouter=True,
+ )
+ .join(
+ DatasetModel,
+ DatasetModel.id == DagScheduleDatasetReference.dataset_id,
+ )
+ .group_by(
+ DagScheduleDatasetReference.dag_id,
+ )
Review Comment:
```suggestion
.join(DatasetModel, DatasetModel.id ==
DagScheduleDatasetReference.dataset_id)
.group_by(DagScheduleDatasetReference.dag_id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
