uranusjr commented on code in PR #31772:
URL: https://github.com/apache/airflow/pull/31772#discussion_r1231775540
##########
airflow/models/pool.py:
##########
@@ -162,19 +163,19 @@ def slots_stats(
pools: dict[str, PoolStats] = {}
- query = session.query(Pool.pool, Pool.slots)
+ query = select(Pool.pool, Pool.slots)
if lock_rows:
query = with_row_locks(query, session=session, **nowait(session))
- pool_rows: Iterable[tuple[str, int]] = query.all()
+ pool_rows: Iterable[Row] = session.execute(query).all()
Review Comment:
So unfortunate this is actually worse than the `tuple` typing since we can
no longer express the innter types 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
