dstandish commented on code in PR #31808:
URL: https://github.com/apache/airflow/pull/31808#discussion_r1227219036
##########
airflow/models/taskinstance.py:
##########
@@ -1693,6 +1693,8 @@ def _execute_task(self, context, task_orig):
execute_callable = getattr(task_to_execute, self.next_method)
if self.next_kwargs:
execute_callable = partial(execute_callable,
**self.next_kwargs)
+ elif self.next_kwargs is not None:
+ raise AirflowException("Task is coming out of deferral without
next_method specified.")
Review Comment:
the reason I added this is because i was checking out the "debuggability"
when user misconfigures this. i.e. when user uses a trigger that does _not_
exit and user provides no method.
without adding this catch, the task will just run the execute method (which
perhaps surprisingly results in an infinite loop of execute and deferral and
back again).
but i think i will change this to make the intention clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
