uranusjr commented on code in PR #31808:
URL: https://github.com/apache/airflow/pull/31808#discussion_r1227536177
##########
airflow/sensors/date_time.py:
##########
@@ -86,11 +86,4 @@ class DateTimeSensorAsync(DateTimeSensor):
"""
def execute(self, context: Context):
- self.defer(
- trigger=DateTimeTrigger(moment=timezone.parse(self.target_time)),
- method_name="execute_complete",
- )
-
- def execute_complete(self, context, event=None):
- """Callback for when the trigger fires - returns immediately."""
- return None
+
self.defer(trigger=DateTimeTrigger(moment=timezone.parse(self.target_time),
exit_task=True))
Review Comment:
Reading this I start to wonder if `end` is a better term than `exit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
