dstandish commented on code in PR #31808:
URL: https://github.com/apache/airflow/pull/31808#discussion_r1227263482
##########
airflow/triggers/temporal.py:
##########
@@ -68,9 +68,8 @@ async def run(self):
while self.moment > timezone.utcnow():
self.log.info("sleeping 1 second...")
await asyncio.sleep(1)
- # Send our single event and then we're done
- self.log.info("yielding event with payload %r", self.moment)
- yield TriggerEvent(self.moment)
+ self.log.info("Sensor time condition reached; marking task successful
and exiting")
+ yield TaskSuccessEvent()
Review Comment:
ok so... there's a potential backcompat problem here
i think it's pretty unlikely but you never know
case is, user subclasses this operator and does some actual work in execute
complete...
do you think we need to worry about that @potiuk @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
