michalc commented on code in PR #31855: URL: https://github.com/apache/airflow/pull/31855#discussion_r1227545742
########## airflow/providers/redis/log/redis_task_handler.py: ########## @@ -0,0 +1,105 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from functools import cached_property +from typing import Any + +from redis import Redis + +from airflow.configuration import conf +from airflow.models import TaskInstance +from airflow.providers.redis.hooks.redis import RedisHook +from airflow.utils.log.file_task_handler import FileTaskHandler +from airflow.utils.log.logging_mixin import LoggingMixin + + +class RedisTaskHandler(FileTaskHandler, LoggingMixin): + """ + RedisTaskHandler is a Python log handler that handles and reads task instance logs. + It extends airflow FileTaskHandler and uploads to and reads from Redis. + + :param base_log_folder: + base folder to store logs locally + :param max_lines: + Maximum number of lines of log to store + If omitted, this is 10000. + :param ttl_seconds: + Maximum number of seconds to store logs + If omitted, this is the equivalent of 28 days. + :param conn_id: + Airflow connection ID for the Redis hook to use + If omitted or None, conf.get("logging", "REMOTE_LOG_CONN_ID") is used. Review Comment: Have changed it to `logging.remote_log_conn_id`, which is how the documentation refers to the setting at https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#logging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
