utkarsharma2 commented on code in PR #31855:
URL: https://github.com/apache/airflow/pull/31855#discussion_r1228875873
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -147,7 +147,7 @@ class FileTaskHandler(logging.Handler):
def __init__(self, base_log_folder: str, filename_template: str | None =
None):
super().__init__()
- self.handler: logging.FileHandler | None = None
+ self.handler: logging.Handler | None = None
Review Comment:
Should have been more specific initially. :)
What I meant was that maybe this change is not required by this PR? since
you have anyway overridden the `self.handler` in class
RedisTaskHandler. Also, `FileTaskHandler` is used in many places, and changing
it here might affect those implementations.
About inheriting from `FileTaskHandler` I'm not sure either, maybe
@bolkedebruin might have more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
