uranusjr commented on code in PR #31855:
URL: https://github.com/apache/airflow/pull/31855#discussion_r1229078343
##########
airflow/utils/log/file_task_handler.py:
##########
@@ -147,7 +147,7 @@ class FileTaskHandler(logging.Handler):
def __init__(self, base_log_folder: str, filename_template: str | None =
None):
super().__init__()
- self.handler: logging.FileHandler | None = None
+ self.handler: logging.Handler | None = None
Review Comment:
This change is OK to me since the base class only really needs to inner
handler to be a `logging.Handler`. It could be moved to a separate PR but since
this is where the change becomes necessary (instead of just a generally good
thing to do) it’s fine to be included here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
