eladkal commented on code in PR #32028:
URL: https://github.com/apache/airflow/pull/32028#discussion_r1235334664
##########
airflow/providers/google/ads/hooks/ads.py:
##########
@@ -73,7 +73,7 @@ class GoogleAdsHook(BaseHook):
:return: list of Google Ads Row object(s)
"""
- default_api_version = "v13"
+ default_api_version = "v14"
Review Comment:
I don't know GoogleAds but this is what I have in mind:
Users who use the hook may be relaying on the default value.
`GoogleAdsHook(..).search(...)`
Before this change it will use v13 after this change it will use v14.
Thus this is a breaking change.
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
