potiuk commented on code in PR #32028:
URL: https://github.com/apache/airflow/pull/32028#discussion_r1235771396
##########
airflow/providers/google/ads/hooks/ads.py:
##########
@@ -73,7 +73,7 @@ class GoogleAdsHook(BaseHook):
:return: list of Google Ads Row object(s)
"""
- default_api_version = "v13"
+ default_api_version = "v14"
Review Comment:
Yeah. Totally agree with @ahidalgob -> there are many libraries that have
braking changes on their own but they are not breaking the API we are exposing
to our users. Surely the users **could** use some stuff from the google ads
client, but technically speaking this is completely outside of our control or
influence.
We cannot break something that we are unaware of. If we take it to extreme,
then every single change in every single dependency or line of code would be a
breaking change (the usual reference to https://www.hyrumslaw.com/.
We will always break something with any change, this is clear, so it really
depends on us what we see as "enough breaking" to make it a "Major" bump. What
would qualify as a breaking change is changing a promise "our" code malks when
publishing what user is supposed to use (i.e. Hooks, Operators, etc. etc. ).
We cannot be responsible for "other's" code - as long as other code does not
impact "our" code, the change is not really breaking.
Similarly to
https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html
- we have
https://airflow.apache.org/docs/apache-airflow-providers-google/stable/_api/airflow/providers/google/index.html#
- and we do not break any of the API's there.
This one is technically equivalent to a chaning version of external
dependency - which we previously agreed to that it is not a breaking chnage on
its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
