ahidalgob commented on code in PR #32028:
URL: https://github.com/apache/airflow/pull/32028#discussion_r1235375647
##########
airflow/providers/google/ads/hooks/ads.py:
##########
@@ -73,7 +73,7 @@ class GoogleAdsHook(BaseHook):
:return: list of Google Ads Row object(s)
"""
- default_api_version = "v13"
+ default_api_version = "v14"
Review Comment:
Hey, you are right but in this case we rely on only two methods from Google
Ads API:
- `GoogleAdsServiceClient.search` used by `Hook.search` and
`Hook.search_proto_plus`
- `CustomerServiceClient.list_accessible_customers` used in
`Hook.list_accessible_customers`
And in this case behaviour is unchanged from v13 to v14 for those methods.
`search` method wasn't changed and `list_accessible_customers` only added one
output-only field to `Customer` (so not breaking), but this is not even visible
from the user's side as we only return another field, not the whole `Customer`
object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
