pankajkoti commented on code in PR #32292:
URL: https://github.com/apache/airflow/pull/32292#discussion_r1248883699
##########
airflow/www/forms.py:
##########
@@ -220,9 +220,9 @@ class ConnectionForm(DynamicForm):
),
)
description = StringField(lazy_gettext("Description"),
widget=BS3TextAreaFieldWidget())
- host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget())
+ host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget(),
filters=[strip_filter])
schema = StringField(lazy_gettext("Schema"),
widget=BS3TextFieldWidget())
- login = StringField(lazy_gettext("Login"), widget=BS3TextFieldWidget())
+ login = StringField(lazy_gettext("Login"),
widget=BS3TextFieldWidget(), filters=[strip_filter])
Review Comment:
I get the fact that most systems may not allow hosts to contain leading or
trailing whitespaces, but thinking critically and loud here in the case of
login, would some users like to have intentionally leading or trailing
whitespaces? I am not sure, just wanted to discuss this once :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
