amoghrajesh commented on code in PR #32292:
URL: https://github.com/apache/airflow/pull/32292#discussion_r1250256796
##########
airflow/www/forms.py:
##########
@@ -220,9 +220,9 @@ class ConnectionForm(DynamicForm):
),
)
description = StringField(lazy_gettext("Description"),
widget=BS3TextAreaFieldWidget())
- host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget())
+ host = StringField(lazy_gettext("Host"), widget=BS3TextFieldWidget(),
filters=[strip_filter])
schema = StringField(lazy_gettext("Schema"),
widget=BS3TextFieldWidget())
- login = StringField(lazy_gettext("Login"), widget=BS3TextFieldWidget())
+ login = StringField(lazy_gettext("Login"),
widget=BS3TextFieldWidget(), filters=[strip_filter])
Review Comment:
I dont think so, it is not a common practice to have trailing or leading
spaces. In between the login name is usually accepted.
In my opinion, we can perform a strip and then if need be try to support
leading/trailing if needed. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
